Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Change how HTTP requests are done to be compatible with stream-http #64

Closed
flaviotordini opened this issue Sep 5, 2020 · 1 comment
Closed
Labels

Comments

@flaviotordini
Copy link

When trying to browserify ytsr, I noticed that the way ytsr makes http requests, while correct, is not supported by stream-http, the "shim" used by webpack and browserify to mimick the nodejs module.

I reported a bug to them: jhiesey/stream-http#116

A small change would make it compatible. In utils.js, replace:
const request = HTTPS.get(ref, options, resp => {

With

options = Object.assign(URL.parse(ref), options);
const request = HTTPS.get(options, resp => {

Would that be ok for you?

@TimeForANinja
Copy link
Owner

actually - planned to roll out the rework this weekend, which uses miniget for the requests...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants