Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: "GetMyIP" or "Get My IP" #121

Closed
bovirus opened this issue Nov 28, 2024 · 2 comments
Closed

Translation: "GetMyIP" or "Get My IP" #121

bovirus opened this issue Nov 28, 2024 · 2 comments
Assignees

Comments

@bovirus
Copy link
Collaborator

bovirus commented Nov 28, 2024

Report a problem with a translation

@Timthreetwelve

In Translation strings you use "Get My IP" when the app name is "GetMyIP".

What's the raeson to use "Get My IP" in translation strings?

Contribute a translation

I believe that in translation strings "Get My IP" should be "GetMyIP" (when it's related to the app).

If this is a contribution, enter the language name and code

Italian (it-IT)

If you wish to have your contribution acknowledged

bovirus

@Timthreetwelve
Copy link
Owner

@bovirus, in my mind the application is named Get My IP. I have been diligent in referring to the application as Get My IP in the documentation, and in any part on the UI that displays the name.

The exceptions are the GitHub repo name and the namespaces, which do not allow spaces, and the executable file names.

Upon review, I see that GetMyIP was used as the application name in the Languages\Strings.xx-XX.xaml files, which I will be happy to update.

Thanks for bringing this to my attention.

Tim

@Timthreetwelve
Copy link
Owner

All of the language files now use Get My IP for the application name.

I also found one instance in the Readme.txt file.

Thanks again,
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants