fix(cdk): fix isFirefox check #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WynieCronje thank you for the PR! Could you please go over other functions in that folder and add lowercasing too? Also, scope for commit message is the package. So in this case it would be |
WynieCronje
changed the title
|
@waterplea Do you prefer another commit? |
|
Don't worry, we squash when we merge PRs |
waterplea
approved these changes
Jan 27, 2021
MarsiBarsi
approved these changes
Jan 27, 2021
fynnfeldpausch
added a commit
to fynnfeldpausch/taiga-ui
that referenced
this pull request
Jan 28, 2021
* main: feat(demo): add page on custom dialogs (taiga-family#159) fix(cdk): fix isFirefox check (taiga-family#158) feat(demo): add guide on using different icon set (taiga-family#157) feat(demo): add `Wrapper` customization page (taiga-family#153) refactor(lang): translated russian text to english (taiga-family#155) docs(demo): fix typos feat(format): number formatting supports custom thousands separator (taiga-family#145) fix(core): fix new CSS vars for height name mismatch and add customization section to demo (taiga-family#149) chore(demo): fix typo chore(demo): try i18n chore(readme): update text chore(kit): `TabsWithMore` make class less generic to avoid collision (taiga-family#142) Revert "chore(package.json): try to change repo name for Github used by" chore(package.json): try to change repo name for Github used by # Conflicts: # projects/addon-editor/components/edit-link/edit-link.template.html # projects/addon-editor/components/toolbar/toolbar.template.html # projects/demo/src/modules/markup/icons/icons.component.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #156
What is the new behavior?
isFirefoxcheck now works as expectedDoes this PR introduce a breaking change?
Other information