-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): use lazy loading strategy in avatar component #185
Conversation
Spasibo, Vadim, for your contribution! :) |
@waterplea, @MarsiBarsi, thanks for submitting my pr 🙂 |
Yes, but in our library every secondary entry point becomes primary entry point for the higher level imports. This way it is already optimized, no matter how deep you import. So we try to use the highest possible point so if you, say, import another directive — it would be placed in the same import line. |
* main: (29 commits) feat(i18n): add Dutch with 100% support (taiga-family#206) chore(i18n): add Turkish to exports feat(i18n): add Turkish with 100% support (taiga-family#200) chore(demo): fix import sample chore(changelog): fix incorrect generated logs chore(release): 2.4.0 chore(docs): update styles on getting-started feat(core): add scss mixin support (taiga-family#165) chore(i18n): add german to exports feat(i18n): Add german localisation (taiga-family#198) fix(core): `Button` fix margin for right aligned icons (taiga-family#173) chore(demo): fix dark theme landing feat(i18n): add Spanish with 100% support (taiga-family#191) fix(button): fix button loader size for XL (taiga-family#174) feat(kit): use lazy loading strategy in avatar component (taiga-family#185) chore(demo): fix typo chore(demo): fix customization examples chore(changelog): fix incorrect generated logs chore(release): 2.3.0 fix(core): `Svg` properly use Angular `Sanitizer` (taiga-family#170) ... # Conflicts: # projects/core/components/button/button.style.less # projects/core/components/hints-host/hint-box/hint-box.style.less # projects/core/components/notification/notification.style.less # projects/core/components/primitive-checkbox/primitive-checkbox.style.less # projects/core/styles/theme/variables.less # projects/demo/src/modules/app/home/home.template.html # projects/kit/components/accordion/accordion-item/accordion-item.style.less # projects/kit/components/input-count/input-count.style.less # projects/kit/components/input-tag/input-tag.style.less # projects/kit/components/tag/tag.style.less
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #62
What is the new behavior?
All avatar images are loaded lazily
Does this PR introduce a breaking change?
Other information