⚡️Add torch.compile Functionality
#716
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdol
changed the title
torch.compile functionality
for more information, see https://pre-commit.ci
shaneahmed
reviewed
Sep 29, 2023
tiatoolbox/utils/misc.py
Outdated
| Returns: | ||
| A tuple containing the result of the function | ||
| and the time taken to execute it in seconds. | ||
| """ |
shaneahmed
reviewed
Oct 5, 2023
tests/test_wsi_registration.py
Outdated
| @@ -21,10 +23,32 @@ | |||
| RNG = np.random.default_rng() # Numpy Random Generator | |||
|
|
|||
|
|
|||
| def test_extract_features(dfbr_features: Path) -> None: | |||
| def test_extract_features_time(dfbr_features: Path, test_count: int = 25) -> None: | |||
There was a problem hiding this comment.
Is this the right place to add this test?
|
https://github.com/pytorch/pytorch/releases/tag/v2.1.0 PyTorch 2.1 now supports torch.compile in Python 3.11 |
shaneahmed
changed the title
torch.compile functionality torch.compile Functionality
…eAnalytics/tiatoolbox into enhance-torch-compile
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #716 +/- ##
========================================
Coverage 99.86% 99.86%
========================================
Files 69 69
Lines 8656 8675 +19
Branches 1653 1655 +2
========================================
+ Hits 8644 8663 +19
Misses 4 4
Partials 8 8 ☔ View full report in Codecov by Sentry. |
* ⚡️ Add `torch.compile` to `PatchPredictor` * 🚨 Remove unused imports * 🐛 Add `rcParam` import * ✅ Add `torch.compile` tests * ✅ Change to a more generic test * 📝 Update test docstring * ⚡️ Reset `TorchDynamo` when changing `torch.compile` mode * 👷 Enable CI checks * 👷 Add python package checks * 🚑 Disable `torch.compile` in Python 3.12+ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🔥 Remove `compile_model` decorator mode for now * 🐛 Fix a bug where a compatbility warning is shown if torch.compile is disabled * 🚸 Check if model is compiled before compiling * 🚨 Disable protected member access check * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🚨 Fix `pre-commit.ci` linting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🚨 Fix another linter error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 📝 Add comment above version check for `torch.compile` * 🚨 Remove unnecessary noqa * ✅ Add test to check if model is already compiled * ✅ Skip test coverage for for checking for python 3.12 --------- Co-authored-by: Abdol A <u2271662@live.warwick.ac.uk> Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
shaneahmed
reviewed
Mar 22, 2024
shaneahmed
reviewed
Mar 22, 2024
Co-authored-by: Shan E Ahmed Raza <13048456+shaneahmed@users.noreply.github.com>
|
Updating PR to fix issues with |
- Refines `torch.compile` implementation in TIAToolbox - Adds the functionality to `DFBRFeatureExtractor`.
|
@Abdol With PyTorch 2.3 release, please can you check if it is compatible with Python 3.12? |
|
@shaneahmed according to release notes, PyTorch 2.3 still does not fully support Python 3.12 including torch.compile. They plan to support it in 2.4. |
|
@Abdol @shaneahmed, PyTorch 2.4 now supports Python 3.12 for |
|
Will get back to this PR from next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR involves integrating PyTorch 2.0's torch.compile functionality to demonstrate performance improvements in torch code. This PR focuses on adding
torch.compiletoPatchPredictor.Notes:
Python 3.11+ is not yet supported forUPDATE: Python 3.11 support was added in PyTorch 2.1torch.compile