-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Add mypy
Type Check to stainnorm
, stainaugment
, patchextraction
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiaqi-Lv
changed the title
🔨 type check 'tools/stainnorm.py'
🔨 type check Feb 16, 2024
tools/stainnorm.py
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #787 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 69 69
Lines 8534 8574 +40
Branches 1641 1641
========================================
+ Hits 8525 8565 +40
Misses 1 1
Partials 8 8 ☔ View full report in Codecov by Sentry. |
shaneahmed
reviewed
Mar 7, 2024
…lbox into mypy merge branch mypy
shaneahmed
changed the title
🔨 mypy type check
🔨 Add Mar 14, 2024
mypy
Type Check to stainnorm
, stainaugment
, patchextraction
shaneahmed
reviewed
Mar 15, 2024
shaneahmed
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jiaqi-Lv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
mypy
checks totools/stainnorm.py
tools/stainaugment.py
tools/patchextraction.py