Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Add mypy Type Check to stainnorm, stainaugment, patchextraction #787

Merged
merged 32 commits into from
Mar 15, 2024

Conversation

Jiaqi-Lv
Copy link
Contributor

@Jiaqi-Lv Jiaqi-Lv commented Feb 16, 2024

Adds mypy checks to

  • tools/stainnorm.py
  • tools/stainaugment.py
  • tools/patchextraction.py

@Jiaqi-Lv Jiaqi-Lv changed the title 🔨 type check 'tools/stainnorm.py' 🔨 type check tools/stainnorm.py Feb 16, 2024
@Jiaqi-Lv Jiaqi-Lv self-assigned this Feb 16, 2024
@Jiaqi-Lv Jiaqi-Lv changed the title 🔨 type check tools/stainnorm.py 🔨 mypy type check Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (ce348e7) to head (b297067).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #787   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files           69       69           
  Lines         8534     8574   +40     
  Branches      1641     1641           
========================================
+ Hits          8525     8565   +40     
  Misses           1        1           
  Partials         8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaneahmed
Copy link
Member

@Jiaqi-Lv Please keep an eye on #786 as there might be a few conflicts.

@shaneahmed shaneahmed added this to the Release v1.6.0 milestone Feb 16, 2024
@Jiaqi-Lv Jiaqi-Lv marked this pull request as ready for review March 13, 2024 14:19
@shaneahmed shaneahmed changed the title 🔨 mypy type check 🔨 Add mypy Type Check to stainnorm, stainaugment, patchextraction Mar 14, 2024
Copy link
Member

@shaneahmed shaneahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jiaqi-Lv

@shaneahmed shaneahmed merged commit 9ab4bcd into develop Mar 15, 2024
15 checks passed
@shaneahmed shaneahmed deleted the mypy branch March 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants