Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️Refine torch.compile and Add to WSI Registration #800

Merged
merged 26 commits into from
Jun 14, 2024

Conversation

Abdol
Copy link
Collaborator

@Abdol Abdol commented Mar 21, 2024

This mini-PR refines torch.compile implementation in TIAToolbox and adds the functionality to DFBRFeatureExtractor.

@Abdol Abdol self-assigned this Mar 21, 2024
@Abdol Abdol added the enhancement New feature or request label Mar 21, 2024
@Abdol Abdol added this to the Release v1.6.0 milestone Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (a767843) to head (646d3da).
Report is 31 commits behind head on enhance-torch-compile.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           enhance-torch-compile     #800   +/-   ##
======================================================
  Coverage                  99.89%   99.89%           
======================================================
  Files                         69       69           
  Lines                       8603     8607    +4     
  Branches                    1646     1647    +1     
======================================================
+ Hits                        8594     8598    +4     
  Misses                         1        1           
  Partials                       8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abdol Abdol marked this pull request as ready for review April 11, 2024 10:24
tiatoolbox/__init__.py Outdated Show resolved Hide resolved
@Abdol
Copy link
Collaborator Author

Abdol commented May 14, 2024

Due to a pytest error occurring in GitHub CI (not on my machine), I disabled automatically enabling torch.compile for compatible GPUs. I intend to re-add this feature as a separate PR for ModelABC.

@Abdol Abdol changed the title ⚡️Add torch.compile to WSI Registration ⚡️Refine torch.compile and add to WSI Registration May 14, 2024
@Abdol Abdol changed the title ⚡️Refine torch.compile and add to WSI Registration ⚡️Refine torch.compile and Add to WSI Registration May 14, 2024
@Abdol
Copy link
Collaborator Author

Abdol commented Jun 3, 2024

A kind follow up on reviewing this PR. Thanks in advance.

Copy link
Collaborator

@mostafajahanifar mostafajahanifar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks neat!

Thanks Abdul, well done 👍

@shaneahmed shaneahmed merged commit e533b85 into enhance-torch-compile Jun 14, 2024
27 checks passed
@shaneahmed shaneahmed deleted the enhance-torch-compile-registration branch June 14, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants