Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"prepush" does not work #3

Closed
mateatslc opened this issue Mar 21, 2018 · 4 comments
Closed

"prepush" does not work #3

mateatslc opened this issue Mar 21, 2018 · 4 comments
Assignees
@tobiastimm
Labels
bug

Comments

@mateatslc
Copy link

Doesn't trigger my prepush npm script (also gave pre-push a try to no avail).
The pre-push hook I'm trying to trigger with husky-hg works fine through hg.
Any idea?

env info: husky-hg@0.14.3, node@8.9.4, npm@5.6.0 on macOS v10.13.3
@mateatslc
Copy link
Author

Looking further, it seems to me that only hooks listed in hg-hooks.json are supported, HOOKS.md suggests a lot more though. Confused...

@tobiastimm
Copy link
Owner

yeah i forgot to change that. The documentation was made after I've created the hooks. Will fix that

@tobiastimm tobiastimm added the bug label Mar 21, 2018
@tobiastimm tobiastimm self-assigned this Mar 21, 2018
@tobiastimm
Copy link
Owner

@mateatslc should work with 0.14.4

@mateatslc
Copy link
Author

Verified, works! Time to fix was amazing too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiastimm tobiastimm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mateatslc @tobiastimm