Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ListElement props leftElements and rightElements #220

Open
michael-braun opened this issue Nov 8, 2021 · 0 comments
Open

Rename ListElement props leftElements and rightElements #220

michael-braun opened this issue Nov 8, 2021 · 0 comments
Assignees
Labels
v5 All issues/PR related to v5 of chayns-components

Comments

@michael-braun
Copy link
Contributor

I think it would increase the usability of the ListItem component, when the props leftElements and rightElements are renamed to left and right. The naming would be less exact, but the typings should be enough.

So far I have not seen a leftElements-prop when developing with react. But left and right seems to be used sometimes for component composition (e.g. in the react-documentation about Composition).

@michael-braun michael-braun added the v5 All issues/PR related to v5 of chayns-components label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 All issues/PR related to v5 of chayns-components
Projects
None yet
Development

No branches or pull requests

2 participants