Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct logical operator for tox_test #123

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

Chuongv
Copy link

@Chuongv Chuongv commented Sep 11, 2016

Check to ensure that all 3 tox instances are up rather than
just one.


This change is Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 11, 2016

:lgtm_strong:

It's not fixing an equality operator, though. It's fixing the logical operator in a truth test. Can you change "equality" to "logical" in the commit message?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Check to ensure that all 3 tox instances are up rather than
just one.
@Chuongv Chuongv force-pushed the chuongv/tox_test_fix branch from 7e9cd0e to d9cd1b0 Compare September 11, 2016 17:48
@GrayHatter
Copy link

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Sep 11, 2016

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@Chuongv Chuongv changed the title Use correct equality operator for tox_test Use correct logical operator for tox_test Sep 12, 2016
@iphydf
Copy link
Member

iphydf commented Sep 12, 2016

I see you've changed it. Would have been nice if you had notified me of the update.

@iphydf iphydf merged commit d9cd1b0 into TokTok:master Sep 12, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants