Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build nTox by default. #303

Merged
merged 1 commit into from
Dec 5, 2016
Merged

Don't build nTox by default. #303

merged 1 commit into from
Dec 5, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 5, 2016

Build it on Travis. It won't be built on the windows builds regardless
of having it enabled globally.

Fixes #292.


This change is Reviewable

Build it on Travis. It won't be built on the windows builds regardless
of having it enabled globally.

Fixes TokTok#292.
@GrayHatter
Copy link

:lgtm_strong:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zetok
Copy link

zetok commented Dec 5, 2016

:lgtm_strong:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@iphydf iphydf added this to the v0.0.6 milestone Dec 5, 2016
@iphydf iphydf merged commit d8ae726 into TokTok:master Dec 5, 2016
@iphydf iphydf deleted the no-ntox branch December 5, 2016 22:22
@iphydf iphydf modified the milestones: v0.0.6, v0.1.0 Dec 10, 2016
@nurupo
Copy link
Member

nurupo commented Dec 14, 2016

:lgtm_strong:


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Dec 14, 2016

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants