Make Travis tests slightly more robust by re-running them. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recently, tests have been timing out more often. This should mitigate it a bit. It will keep rerunning failed tests until travis times out. |
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
cebe
reviewed
Jan 19, 2017
| # Keep running tests until they eventually succeed or Travis times out after | ||
| # 50 minutes. This cuts down on the time lost when tests fail, because we no | ||
| # longer need to manually restart the build and wait for compilation. | ||
| "$@" || TESTS "$@" |
There was a problem hiding this comment.
50 minutes is a bit too much imo. Maybe make a limit here on run it 3 times and then fail? If tests are broken this will take a lot of travis capacity that could be used on building other repos.
|
Rerun tests until stars align and they pass? :) Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is