Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list malloc(0) bug #510

Merged
merged 2 commits into from
Mar 26, 2017
Merged

Fix list malloc(0) bug #510

merged 2 commits into from
Mar 26, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Mar 12, 2017

This change is Reviewable

@sudden6
Copy link

sudden6 commented Mar 12, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


toxcore/list.c, line 121 at r1 (raw file):

{
    if (new_size == 0) {
        list->data = NULL;

the memory should also get freed


Comments from Reviewable

@Diadlo
Copy link
Author

Diadlo commented Mar 12, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


toxcore/list.c, line 121 at r1 (raw file):

Previously, sudden6 wrote…

the memory should also get freed

Done.


Comments from Reviewable

@sudden6
Copy link

sudden6 commented Mar 12, 2017

:lgtm_strong:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Mar 25, 2017

Enable the checkbox allowing pushes from collaborators.

@Diadlo
Copy link
Author

Diadlo commented Mar 25, 2017

@iphydf Done

@iphydf iphydf added this to the v0.1.7 milestone Mar 26, 2017
@iphydf iphydf merged commit c07c61c into TokTok:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants