Reverting tox_loop PR changes #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 21 of 21 files at r1. Comments from Reviewable |
|
Why lgtm? This isn't meant to be merged. |
|
lgtm |
|
@robinlinden @iphydf So, do we want to merge this? |
|
I think we should merge this and ask @Ansa89 to open a new PR with the tox_loop code. I don't want to make a release while OS X is broken. |
nurupo
changed the title
nurupo
force-pushed
the
test-removing-tox-loop
branch
from
547e22d to
c25e3d2
Compare
|
@vassad It breaks toxcore tests for OSX. |
|
@nurupo thx, didn't see this PR ... |
|
I guess this never got its new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to see if reverting the tox loop PR would fix OS X tests, before actually looking into the code to see what could have broken them.
This change is