Do not use else after return.

[iphydf]

http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code

---

This change is

[JFreegman]

---

Reviewed 31 of 31 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

Comments from Reviewable

[nurupo]

Reviewed 1 of 31 files at r1, 23 of 23 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

toxcore/DHT.c, line 2507 [r2] (raw file):

            return dht->cryptopackethandlers[number].function(dht->cryptopackethandlers[number].object, source, public_key,
                    data, len);
        } /* If request is not for us, try routing it. */

Move the comment one line lower?

---

toxcore/net_crypto.c, line 1396 [r2] (raw file):

        } else {
            //TODO?
        }

I think that else part has to stay for the 'TODO' to make sense.

---

toxcore/net_crypto.c, line 1543 [r2] (raw file):

            }

            return 0;

That's interesting. Looks like some logic error with that unnecessary return 0, or someone just forgot to remove it while extending code.

---

Comments from Reviewable

[nurupo]

Reviewed 7 of 31 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[iphydf]

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

toxcore/DHT.c, line 2507 [r2] (raw file):

Previously, nurupo wrote…

Move the comment one line lower?

Done.

---

toxcore/net_crypto.c, line 1396 [r2] (raw file):

Previously, nurupo wrote…

I think that else part has to stay for the 'TODO' to make sense.

Does the TODO make sense?

---

Comments from Reviewable

[nurupo]

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

toxcore/net_crypto.c, line 1396 [r2] (raw file):

Previously, iphydf wrote…

Does the TODO make sense?

Can't we just keep the `} else { // TODO? }`? It's not obvious that with `// else TODO?` you mean the `else` of the if-statement above, at least to me it's not.

---

Comments from Reviewable

[iphydf]

Review status: 29 of 31 files reviewed at latest revision, 2 unresolved discussions.

---

toxcore/net_crypto.c, line 1396 [r2] (raw file):

Previously, nurupo wrote…

Can't we just keep the } else { // TODO? }? It's not obvious that with // else TODO? you mean the else of the if-statement above, at least to me it's not.

How about this?

---

Comments from Reviewable

[nurupo]

---

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable