fix: friend requests with very long messages are no longer dropped #2720
+65
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it's Milestone v0.2.20, converted it to a draft to prevent the auto-merge by the bot. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2720 +/- ##
==========================================
- Coverage 73.09% 73.01% -0.09%
==========================================
Files 149 149
Lines 30533 30533
==========================================
- Hits 22319 22294 -25
- Misses 8214 8239 +25 ☔ View full report in Codecov by Sentry. |
JFreegman
force-pushed
the
request_message_fix
branch
4 times, most recently
from
541b497
to
404479b
Compare
JFreegman
force-pushed
the
request_message_fix
branch
from
404479b
to
6bce900
Compare
JFreegman
force-pushed
the
request_message_fix
branch
from
6bce900
to
840b152
Compare
iphydf
approved these changes
Nov 27, 2024
iphydf
reviewed
Nov 27, 2024
This is a band-aid solution that prevents friend requests with long messages from being dropped. However it doesn't solve the underlying problem, described here: TokTok#2719
JFreegman
force-pushed
the
request_message_fix
branch
from
840b152
to
29d1043
Compare
Green-Sky
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a band-aid solution that prevents friend requests with long messages from being dropped. However it doesn't solve the underlying problem, described here: #2719
This change is