[Bug]: Stable release reports running nightly

[jason123santa]

Contact Details (e.g. Tox ID or email)

No response

qTox Version

1.18.0

Commit Hash

No response

Toxcore Version

0.2.20

Qt Version

6.8.1

Steps to reproduce

1. Start qTox
2. Go to settings
3. about

Observed Behavior

It says that its running an unstable nightly version of qtox even though I installed the latest 1.18.0 release.

Expected Behavior

It should say version 1.18.0

Reproducibility

Always

Operating System

Linux

Operating System version/distro/name/etc.

Debian 12

Relevant log output

No response

[iphydf]

Thanks for reporting. This will be fixed in 1.18.1 by #356. I'm leaving this ticket open until that release because this will be noticed by others.

[iphydf]

Fixed in RC 2.

[4fury-c3440d8]

I built release 1.18.1 from xz-tarball. Error persist. qTox running from appimage checks version correctly. @iphydf

[iphydf]

If you build from tarballs, you'll need to set some cmake flags yourself (GIT_DESCRIBE and friends). Maybe we can hard code those in the release tarballs we build next time.

[4fury-c3440d8]

These flags and their descriptions are missing from the cmake -LA output.

GIT_VERSION is a hash a commit. GIT_DESCRIBE is a version number. Am I right?
What value should it have GIT_DESCRIBE_EXACT?

[iphydf]

https://github.com/TokTok/qTox/actions/runs/12624212845/job/35174169530#step:4:520

-- Git version: 307d086ba45ebd3702c4a22cf1f899d4350efdfa
-- Git describe: v1.18.1
-- Git describe exact: v1.18.1

[4fury-c3440d8]

OK. Thanks!