Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle chore: Add debug and LLVM asan build options #144

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Nov 19, 2020

A duplicate of #143 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • astyle

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/toxic.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

JFreegman and others added 2 commits November 19, 2020 13:06
In addition, the default build now uses -O3 and has no debug symbols.
-Wmissing-field-initializer was removed due to false positives on
newer versions of clang.
@auto-add-label auto-add-label bot added the chore Updating grunt tasks etc; no production code change label Nov 19, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JFreegman
❌ restyled-commits
You have signed the CLA already but the status is still pending? Let us recheck it.

@restyled-io restyled-io bot closed this Nov 19, 2020
@restyled-io restyled-io bot deleted the restyled/pull-143 branch November 19, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants