Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Concatenate using global indexes #3

Closed
TomNicholas opened this issue Dec 7, 2018 · 0 comments
Closed

Concatenate using global indexes #3

TomNicholas opened this issue Dec 7, 2018 · 0 comments
Labels
enhancement New feature or request Requires BOUT changes Requires some alteration to BOUT++ behaviour Requires xarray changes Requires some changes to be merged into xarray

Comments

@TomNicholas
Copy link
Owner

TomNicholas commented Dec 7, 2018

If BOUT is changed upstream to write out the global grid point indexes to each file, then xBOUT can use them to infer the order in which the datasets should be concatenated.

This would also require implementing an infer_order_from_coords option in xarray.auto_combine(), as discussed [here] (pydata/xarray#2159).

This would move even more of the concatenation logic upstream to xarray, as then we wouldn't need to create a nested list-of-lists anymore, we could just pass the unordered glob of all dump files.

On the other hand this might make the open_mfdataset() call considerably slower, as it will have to read the coordinate variables in order to order the datasets.

@TomNicholas TomNicholas added enhancement New feature or request Requires BOUT changes Requires some alteration to BOUT++ behaviour Requires xarray changes Requires some changes to be merged into xarray labels Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Requires BOUT changes Requires some alteration to BOUT++ behaviour Requires xarray changes Requires some changes to be merged into xarray
Projects
None yet
Development

No branches or pull requests

1 participant