Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The database specified in the config is forced to start with a slash regardless of the server OS #371

Closed
mariocarro opened this issue Aug 23, 2024 · 4 comments

Comments

@mariocarro
Copy link

This prevents connecting to databases on Windows servers.

@Tomas2D
Copy link
Owner

Tomas2D commented Aug 24, 2024

What's the proposed solution?

@mariocarro
Copy link
Author

I removed (commented out) the lines:

if (customConfig.connection.database[0] !== '/') {
  customConfig.connection.database = `/${customConfig.connection.database}`
}

in the constructor or Client_Firebird (lines 31-33 of index.js). That change alone allows the connection to succeed and afterwards everything else works without a hitch.

This change also has the added benefit of allowing the use of database aliases which didn't work before (because everything was treated as a file path).

@Tomas2D
Copy link
Owner

Tomas2D commented Aug 24, 2024

Great. I will update the package later today and let you know.

@Tomas2D
Copy link
Owner

Tomas2D commented Aug 24, 2024

Fixed in version 2.0.3

@Tomas2D Tomas2D closed this as completed Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants