Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking changes in 1.4 #753

Closed
marci4 opened this issue Aug 14, 2018 · 1 comment
Closed

Breaking changes in 1.4 #753

marci4 opened this issue Aug 14, 2018 · 1 comment
Assignees
@marci4
Labels
Breaking changes Refactor
Milestone
Release 1.4.0

Comments

@marci4
Copy link
Collaborator

marci4 commented Aug 14, 2018 •
edited
Loading

This issue is used to track all the breaking changes coming with 1.4.0.

Since this is the first major release, I would like to use this opportunity to clean up some old things.

Breaking changes

  • Enum ReadyState was moved (and renamed) to to org.java_websocket.enums.ReadyState
  • Enum Opcode was moved to org.java_websocket.enums.Opcode
  • Enum Role was moved to org.java_websocket.enums.Role
  • Enum HandshakeState was moved to org.java_websocket.enums.HandshakeState
  • Enum CloseHandshakeType was moved to org.java_websocket.enums.CloseHandshakeType
  • Renamed LimitExedeedException to LimitExceededException

Removal due to deprecation

  • ReadyState.CONNECTING
  • AbstractClientProxyChannel
  • WebSocketListener.onWebsocketMessageFragment( WebSocket conn, Framedata frame )
  • WebSocketAdapter.onWebsocketMessageFragment( WebSocket conn, Framedata frame )
  • WebSocketClient.onWebsocketMessageFragment( WebSocket conn, Framedata frame )
  • WebSocketServer.onWebsocketMesageFragment( WebSocket conn, Framedata frame )
  • WebSocketImpl.isConnecting()
  • WebSocket.isConnectiong()
  • WebSocketClient.isConnecting()
  • WebSocketClient.onFragment( Framedata frame )
  • WebSocketServer.onFragment( WebSocket conn, Framedata fragment )
  • WebSocketServer.connections()
@marci4 marci4 added this to the Release 1.4.0 milestone Aug 14, 2018
@marci4 marci4 mentioned this issue Aug 14, 2018
Merged
8 tasks
@marci4
Copy link
Collaborator Author

marci4 commented Feb 17, 2019

We have a code close for 1.4.0.

Best regards,
Marcel

@marci4 marci4 closed this as completed Feb 17, 2019
@marci4 marci4 self-assigned this Feb 17, 2019
@nikoTM nikoTM mentioned this issue Oct 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marci4 marci4

Labels
Breaking changes Refactor
Projects
None yet
Milestone
Release 1.4.0
Development

No branches or pull requests
1 participant
@marci4