this adds support for both number keys and shift+number keys #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his adds support for both number keys and shift+number keys. - resolves TooTallNate#11 - resolves TooTallNate#14 - resolves TooTallNate#16
| // number | ||
| key.name = s; | ||
|
|
||
| } else if (s.length === 1 && '~!@#$%^&*()_+'.indexOf(s) !== -1) { |
There was a problem hiding this comment.
Wouldn't this only be true for US-ASCII keyboards?
There was a problem hiding this comment.
good point. would you consider merging, to resolve this for US-ASCII keyboards, then we can work on support for non-US-ASCII? No worries either way, I'm happy to try to figure out a more robust solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three other PRs for number keys, sorry for the noise. Hopefully the shift+number makes it worth it :)