From 9b1cb20c010a8d94637189f7d5217bbc109068b5 Mon Sep 17 00:00:00 2001
From: Luka Peschke <luka.peschke@toucantoco.com>
Date: Fri, 22 Nov 2024 09:46:54 +0100
Subject: [PATCH] chore: remove CacheEnum.HDF (#909)

Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
---
 CHANGELOG.md        |  4 ++++
 peakina/cache.py    | 10 ----------
 tests/test_cache.py |  4 ++--
 3 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5089b537..72a7616e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+### Changed
+
+- Removed `CacheEnum.HDF`
+
 ## [0.14.0] -  2024-11-21
 
 ### Added
diff --git a/peakina/cache.py b/peakina/cache.py
index 26043ae2..19eb764f 100644
--- a/peakina/cache.py
+++ b/peakina/cache.py
@@ -1,4 +1,3 @@
-import warnings
 from abc import ABCMeta, abstractmethod
 from collections.abc import Callable
 from contextlib import suppress
@@ -20,21 +19,12 @@ class InMemoryCached(TypedDict):
 
 class CacheEnum(str, Enum):
     MEMORY = "memory"
-    # FIXME: to be removed in v0.15.0
-    HDF = "hdf"
     PICKLE = "pickle"
 
 
 class Cache(metaclass=ABCMeta):
     @staticmethod
     def get_cache(kind: CacheEnum, *args: Any, **kwargs: Any) -> "Cache":
-        if kind == CacheEnum.HDF:
-            warnings.warn(
-                "HDF Cache has been removed in v0.14.0, PickleCache will be used instead. "
-                "This will be an error in v0.15.0, please use CacheEnum.PICKLE instead",
-                DeprecationWarning,
-            )
-            kind = CacheEnum.PICKLE
         if kind == CacheEnum.PICKLE:
             return PickleCache(*args, **kwargs)
         else:
diff --git a/tests/test_cache.py b/tests/test_cache.py
index e06ec2be..0c8cd7a0 100644
--- a/tests/test_cache.py
+++ b/tests/test_cache.py
@@ -33,7 +33,7 @@ def test_inmemory_cache(df_test):
 
 def test_pickle_cache(mocker, tmp_path, df_test):
     """two pickle caches pointing to the same directory are equivalent"""
-    c1 = Cache.get_cache(CacheEnum.HDF, cache_dir=tmp_path)
+    c1 = Cache.get_cache(CacheEnum.PICKLE, cache_dir=tmp_path)
     c2 = Cache.get_cache(CacheEnum.PICKLE, cache_dir=tmp_path)
     assert isinstance(c1, PickleCache)
     assert isinstance(c2, PickleCache)
@@ -60,7 +60,7 @@ def cache(request: Any, tmpdir: str) -> Cache:
     if request.param == "memory":
         return Cache.get_cache(CacheEnum.MEMORY)
     elif request.param == "hdf":
-        return Cache.get_cache(CacheEnum.HDF, cache_dir=tmpdir)
+        return Cache.get_cache(CacheEnum.PICKLE, cache_dir=tmpdir)
     else:
         raise ValueError("invalid internal test config")