Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: #5630

Closed
Olzie-12 opened this issue Jan 14, 2022 · 4 comments
Closed

Suggestion: #5630

Olzie-12 opened this issue Jan 14, 2022 · 4 comments

Comments

@Olzie-12
Copy link

Please explain your feature request to the best of your abilities:

You've added the TownPreAddResidentEvent and this fires before the actual event happens, is it possible we can get the pre version of when you remove the resident as well?

@Olzie-12
Copy link
Author

In the docs, it says after. But in the code its firing before. So a bit confused

@LlmDl
Copy link
Member

LlmDl commented Jan 14, 2022

In the docs, it says after. But in the code its firing before. So a bit confused

Not sure what you mean here.

@LlmDl
Copy link
Member

LlmDl commented Jan 14, 2022

Are you looking to be able to cancel a resident leaving a town?

@LlmDl LlmDl added the Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. label Jan 14, 2022
@Olzie-12
Copy link
Author

Are you looking to be able to cancel a resident leaving a town?

No, i want the event to fire before it actually happens. But i guess it already does that, but in the docs it says here:
Fired after a resident has been removed from a town.

But, if you look here:

BukkitTools.getPluginManager().callEvent(new TownRemoveResidentEvent(this, town));

It fires it before its the resident has been removed from the town.

So yes, thats what i wanted. But the docs say its been fired after, and you would of thought the event would of been named with "Pre" like all the others are.

@LlmDl LlmDl added Completed and removed Need Feedback Something is required of the submitter. Tickets will be closed after 14 days with no feedback. labels Jan 14, 2022
@LlmDl LlmDl added this to the 0.98.0.0 milestone Jan 14, 2022
@LlmDl LlmDl closed this as completed in 8f65d4c Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants