Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Spawn point ring drawing is very unoptimized #5899

Closed
ks-hl opened this issue May 7, 2022 · 1 comment
Closed

Suggestion: Spawn point ring drawing is very unoptimized #5899

ks-hl opened this issue May 7, 2022 · 1 comment

Comments

@ks-hl
Copy link

ks-hl commented May 7, 2022

Please explain your feature request to the best of your abilities:

It looks like SpawnPoint#drawParticle() is called for every single spawn point in memory, regardless of whether or not it's loaded. This is resulting in about 10k synchronous tasks being scheduled on my server. Seems inefficient. I've disabled the spawn point ring because of it, but given it's something enabled by default it might be worth optimizing.

@LlmDl
Copy link
Member

LlmDl commented May 7, 2022

Have you got any timings showing the 10k tasks?

@LlmDl LlmDl closed this as completed in 718da4f May 7, 2022
@LlmDl LlmDl added the Completed label May 7, 2022
@LlmDl LlmDl self-assigned this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants