Include ActionState to MatchingEngineActionStateResult #1064
Conversation
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: pre-commit-checks
Refactoring to include the `awaited_action` watch channel `notify_channel: watch::Sender<Arc<ActionState>>` to be provided via `MatchingEngineActionStateResult`. This aids the matching engine's need for access to `OperationId`.
adam-singer
force-pushed
the
adams/include-action-state-to-matching-engine-action-state-result
branch
from
4217ac7
to
82bf622
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
Description
Refactoring to include the
awaited_actionwatch channelnotify_channel: watch::Sender<Arc<ActionState>>to be provided viaMatchingEngineActionStateResult. This aids the matching engine's need for access toOperationId.Fixes #1063
Type of change
Please delete options that aren't relevant.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is