Disable some workflows on PRs that only change docs #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit risky and we might want to reenable some of these, but let's see how this goes. Reasoning for the disabled workflows: - `main.yaml`: This is independent of docs - `native-bazel.yaml`: Dev-only workflow and covered by nix workflows. - `native-cargo.yaml`: Dev-only workflow and covered by nix workflows. - `sanitizers.yaml`: Independent of the docs. This change deliberately doesn't touch the Nix workflows as parts of the development tooling used by doc workflows relies on it.
blakehatch
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit risky and we might want to reenable some of these, but let's see how this goes. Reasoning for the disabled workflows:
main.yaml: This is independent of docsnative-bazel.yaml: Dev-only workflow and covered by nix workflows.native-cargo.yaml: Dev-only workflow and covered by nix workflows.sanitizers.yaml: Independent of the docs.This change deliberately doesn't touch the Nix workflows as parts of the development tooling used by doc workflows relies on it.
This change is