Convert RedisError into nativelink Error #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-singer
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Maybe this is a later change, should we have a nativelink-redis package that hosts things coupled to redis? @allada wdyt?
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained
Makes convenience type for stream of action state results accessible from from the outside functions that will return it. Additionally changes filtering operations to be an async function so that blocking will not have to be used when getting the actions to filter is an async operation.
Adds the ability to convert a RedisError into a Nativelink Error. This will dramatically simplifies error handling when dealing with errors returned by the new redis backend for the scheduler.
allada
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 5 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
zbirenbaum
commented
Jun 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 5 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to convert a RedisError into a Nativelink Error. This will dramatically simplifies error handling when dealing with errors returned by the new redis backend for the scheduler.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Compiler accepts conversion into nativelink_error::Error from RedisError::into
Checklist
bazel test //...passes locallygit amendsee some docsThis change is