bump serde to more current version #966
Conversation
There was a problem hiding this comment.
This change doesn't actually affect compilation. The Cargo.lock uses 1.203 which is the latest version at the moment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and 2 discussions need to be resolved
-- commits line 2 at r1:
nit: Bump
nativelink-config/Cargo.toml line 9 at r1 (raw file):
byte-unit = "5.1.4" humantime = "2.1.0" serde = { version = "1.0.201", features = ["derive"] }
nit: 1.0.203.
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 2 discussions need to be resolved
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit: Bump
nit: remove period
MarcusSorealheis
changed the title
MarcusSorealheis
force-pushed
the
bump-Serde
branch
from
2925e6c
to
ca4562e
Compare
There was a problem hiding this comment.
Correct. But we should make this challenge.
Reviewable status: 0 of 1 LGTMs obtained, and 1 discussions need to be resolved
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: 1 of 1 LGTMs obtained, and 2 discussions need to be resolved
-- commits line 2 at r2:
nit: Caps and remove period.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 2 of 1 LGTMs obtained
Description
Upon rebasing #891, I realized that I accidentally dropped the Serde version. This PR restores it (unless that breaks something).
Checklist
bazel test //...passes locallygit amendsee some docsThis change is