Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SIMULATION output (per time period/iteration) such as gaps and computation times for easy post simulation analysis #122

Open
MarkRaadsen opened this issue Jul 6, 2024 · 3 comments · Fixed by #98
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@MarkRaadsen
Copy link
Member

add in memory model + then implement for the various other repository implementations (CSV, memory etc.).

Main reason for this is to have some stats per iteration that can easily be digested in Excel or Python without having to sift through the logs

Start with adding:
iteration gap
iteration computation time

@MarkRaadsen MarkRaadsen self-assigned this Jul 6, 2024
@MarkRaadsen MarkRaadsen added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 6, 2024
@MarkRaadsen MarkRaadsen added this to the Version 0.5.0 milestone Jul 6, 2024
@MarkRaadsen MarkRaadsen linked a pull request Jul 6, 2024 that will close this issue
MarkRaadsen added a commit that referenced this issue Jul 6, 2024
…nue with actually being able to extract the convergence gap
MarkRaadsen added a commit that referenced this issue Jul 7, 2024
…signment as well). Not fully tested and needs additional features for it to be complete
@MarkRaadsen
Copy link
Member Author

MarkRaadsen commented Jul 7, 2024

  • iteration index not yet supported for simulation
  • only planit csv supported for simulation
  • check if works for traditional static
  • check if works for sLTM
  • implement for memory output
  • allow for simulation results to be persisted each iteration (configure per output type)
  • allow for simulation data to be consolidated into a single file, i.e., gather all results in memory and write out after finalising the simulation instead of per iteration
  • Add #paths added as option + num added/removed
  • Add runtime - for sLTM per iteration

@MarkRaadsen
Copy link
Member Author

#122 consolidated simulation data draft implemented for PLANitOutputFormatter

MarkRaadsen pushed a commit that referenced this issue Jul 26, 2024
…o a 500 iteration route choice test in PLANitIO so it is part of CI (only tested for PLANit output format, no other output formats)
MarkRaadsen added a commit that referenced this issue Jul 28, 2024
… added, changed rc convergence gap property from float to double, minor refactoring
MarkRaadsen pushed a commit that referenced this issue Aug 15, 2024
MarkRaadsen pushed a commit that referenced this issue Aug 15, 2024
- added functionality to count number of paths in ODPath interfaces (and implementations)
@MarkRaadsen
Copy link
Member Author

MarkRaadsen commented Aug 15, 2024

  • implement for TNTP output
  • add support for traditional static assignment for relevant simulation data output
  • add smoothing step size as option to persist for simulation data
  • make sure convergence gap that is persisted has higher precision than regular floating point results

MarkRaadsen pushed a commit that referenced this issue Aug 15, 2024
MarkRaadsen pushed a commit that referenced this issue Aug 22, 2024
…for convergence gap output in simulation data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant