Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masking Capability for Input Component #391

Closed
muratcorlu opened this issue Jan 25, 2023 · 4 comments · Fixed by #883
Closed

Masking Capability for Input Component #391

muratcorlu opened this issue Jan 25, 2023 · 4 comments · Fixed by #883
Assignees
@doganozturk
Labels
ADR-required An Architectural Design Record is needed for this issue bl-input Input component good first issue Good for newcomers released

Comments

@muratcorlu
Copy link
Contributor

muratcorlu commented Jan 25, 2023 •
edited
Loading

Leading and trailing texts (like currencies or units) would be possible to put our Input component. Details will come later.
@muratcorlu muratcorlu added ADR-required An Architectural Design Record is needed for this issue bl-input Input component labels Jan 25, 2023
@muratcorlu muratcorlu mentioned this issue Jan 25, 2023
Closed
@muratcorlu
Copy link
Contributor Author

Design changes are ready: https://www.figma.com/file/RrcLH0mWpIUy4vwuTlDeKN/Baklava-Design-Guide?node-id=4%3A5586&t=dpos9bPGKoCkqo5m-0

@muratcorlu muratcorlu added this to the 2023 Q2 milestone Mar 28, 2023
@muratcorlu muratcorlu modified the milestones: 2023 Q2, 2023 Q3 Jul 14, 2023
@talatatac talatatac self-assigned this Oct 25, 2023
@leventozen leventozen removed this from the 2023 Q3 milestone Nov 30, 2023
@buseselvi buseselvi added the good first issue Good for newcomers label Dec 14, 2023
@buseselvi buseselvi assigned fatih22yilmaz and unassigned talatatac Feb 22, 2024
@doganozturk doganozturk self-assigned this Mar 29, 2024
@buseselvi buseselvi assigned ozkersemih and unassigned doganozturk Apr 4, 2024
@doganozturk doganozturk assigned doganozturk and unassigned ozkersemih Apr 4, 2024
@doganozturk doganozturk changed the title Leading/Trailing text for Input field Masking Capability for Input Component Apr 4, 2024
@doganozturk
Copy link
Contributor

This task had originally title Leading/Trailing text for Input field.

We talked about this and decided to implement this feature with usage of input's placeholder functionality and usage of input masking.

@doganozturk
Copy link
Contributor

Our latest decision is not to implement input masking as a feature but provide detailed examples with compatible libraries. Leading/Trailing text for Input field should be achieved by placeholder usage and input masking integration with 3rd party libraries such as IMask and Maskito.

@doganozturk doganozturk mentioned this issue May 3, 2024
Closed
@doganozturk doganozturk mentioned this issue Jun 12, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doganozturk doganozturk

Labels
ADR-required An Architectural Design Record is needed for this issue bl-input Input component good first issue Good for newcomers released
Projects
Baklava Design System
Archived in project
Milestone
No milestone
7 participants
@muratcorlu @leventozen @doganozturk @fatih22yilmaz @talatatac @ozkersemih @buseselvi