Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the latest tag for the version on the builder scripts #7174

Closed
2 tasks done
xoriole opened this issue Nov 16, 2022 · 3 comments
Closed
2 tasks done

Using the latest tag for the version on the builder scripts #7174

xoriole opened this issue Nov 16, 2022 · 3 comments
Assignees

Comments

@xoriole
Copy link
Contributor

xoriole commented Nov 16, 2022

Right now, we use git describe to get the version. Sometimes this can return the earlier version if the last annotated tag is older and the newer tags were not annotated.

By default (without --all or --tags) git describe only shows annotated tags.

Tag objects (created with -a, -s, or -u) are called "annotated" tags; they contain a creation date, the tagger name and e-mail, a tagging message, and an optional GnuPG signature. Whereas a "lightweight" tag is simply a name for an object (usually a commit object).

At the current commit of main:

$ git describe
>> v7.11.0-RC1-908-g9aba4ae00

$ git describe --tags
>> v7.12.1-405-g9aba4ae00

Using --tags switch will return the last reachable tag irrespective of annotated or not which would be a better indication of the current version of Tribler.

Expected changes in:

  • Github workflows (build_*.yml)
  • Jenkins build jobs

References:

@drew2a
Copy link
Contributor

drew2a commented Nov 16, 2022

I can implement the change for GitHub Actions.

@drew2a
Copy link
Contributor

drew2a commented Nov 17, 2022

GitHub workflows have been changed. I've also changed the main post here and added checkboxes:

image

As my part is done, unassigning myself...

@drew2a drew2a removed their assignment Nov 17, 2022
@xoriole xoriole self-assigned this Nov 24, 2022
@xoriole
Copy link
Contributor Author

xoriole commented Nov 29, 2022

Jenkins build job is updated and the build artifacts show the correct version.
https://jenkins-ci.tribler.org/job/Build-Tribler_release/job/Build/491/

build-491-successful

@xoriole xoriole closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants