Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry uses incorrect stacktrace for CoreCrashedError #7713

Closed
drew2a opened this issue Nov 22, 2023 · 1 comment
Closed

Sentry uses incorrect stacktrace for CoreCrashedError #7713

drew2a opened this issue Nov 22, 2023 · 1 comment
Assignees
Milestone

Comments

@drew2a
Copy link
Contributor

drew2a commented Nov 22, 2023

An example: https://sentry.tribler.org/organizations/tribler/issues/2480

Stacktrace:

PyInstaller\loader\pyimod03_importers.py:495
UserWarning: You are using cryptography on a 32-bit Python on a 64-bit Windows Operating System. Cryptography will be significantly faster if you switch to using a 64-bit Python.

CoreCrashedError
The Tribler core has unexpectedly finished with exit code 1 and status: 0.

Error message: Application error

Should be:

CoreCrashedError
The Tribler core has unexpectedly finished with exit code 1 and status: 0.

Error message: Application error

This results in CoreCrashedError mimicking unrelated errors, making it invisible in Sentry:
image

@drew2a drew2a added this to the 7.14.0 milestone Nov 22, 2023
@drew2a drew2a self-assigned this Nov 22, 2023
@drew2a
Copy link
Contributor Author

drew2a commented Nov 24, 2023

This logic was introduced in #7066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant