Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #5484

Merged
merged 11 commits into from
Jul 19, 2020
Merged

Various fixes #5484

merged 11 commits into from
Jul 19, 2020

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Jul 17, 2020 •
edited
Loading

Fixes #5481, fixes #5482, partially addresses #5485

@ghost
Copy link

ghost commented Jul 17, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 0.692 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@devos50 devos50 mentioned this pull request Jul 17, 2020
Closed
@devos50 devos50 force-pushed the various_fixes branch 4 times, most recently from 157db67 to f913c3d Compare July 18, 2020 08:30
ichorid
ichorid reviewed Jul 18, 2020
View reviewed changes
src/run_tribler.py Outdated Show resolved Hide resolved
This was linked to issues Jul 18, 2020
Our dependency check on startup is broken #5482
Closed
Remove run_tribler.py cp65001 support #5481
Closed
@devos50
Copy link
Contributor Author

devos50 commented Jul 19, 2020

Ready for review. The failing checks are expected.

@devos50 devos50 marked this pull request as ready for review July 19, 2020 09:32
ichorid
ichorid suggested changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the latest IPv8 pointer. @egbertbouman fixed a really nasty tunnels error there.

@devos50
Copy link
Contributor Author

devos50 commented Jul 19, 2020

@ichorid done!

@ichorid
Copy link
Contributor

ichorid commented Jul 19, 2020

What's the problem with Windows GUI tests?

@ichorid
Copy link
Contributor

ichorid commented Jul 19, 2020

retest this please

qstokkink
qstokkink reviewed Jul 19, 2020
View reviewed changes
src/run_tribler.bat Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50 devos50 requested a review from qstokkink July 19, 2020 14:21
@devos50 devos50 merged commit ca69c24 into Tribler:release-7.5 Jul 19, 2020
@devos50 devos50 deleted the various_fixes branch July 19, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid approved these changes

@qstokkink qstokkink qstokkink approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our dependency check on startup is broken Remove run_tribler.py cp65001 support
3 participants
@devos50 @ichorid @qstokkink