Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #6839

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Mar 30, 2022

Related to #6352 #6512 #6840

This PR adds libtorrent==1.2.15 to requirements.txt.

This version of libtorrent has been tested on macOS, Linux, and Windows.

@drew2a
Copy link
Contributor Author

drew2a commented Mar 30, 2022

Tests on Windows 64-bit reported the following error:

ImportError while loading conftest 'E:\jenkins\workspace\GH_Tribler_PR_Tests\PR_win64_pytest\tribler\src\tribler\core\conftest.py'.
src\tribler\core\conftest.py:17: in <module>
    from tribler.core.components.libtorrent.download_manager.download_manager import DownloadManager
src\tribler\core\components\libtorrent\download_manager\download_manager.py:53: in <module>
    lt.create_ut_metadata_plugin,
src\tribler\core\components\libtorrent\utils\libtorrent_helper.py:17: in __getattr__
    raise ImportError('libtorrent library is not installed')
E   ImportError: libtorrent library is not installed

UPD: we have tested libtorrent==1.2.15 on a Windows machine. It works fine along with choco install openssl.

Ref: https://github.com/arvidn/libtorrent/blob/RC_2_0/.github/workflows/windows.yml

@drew2a drew2a added this to the 7.13.0 April milestone Mar 30, 2022
@drew2a
Copy link
Contributor Author

drew2a commented Apr 1, 2022

I'm testing hidden peer discovery by executing the following commands:

export LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libtcmalloc_minimal.so.4"
export PYTHONPATH=$PWD/tribler/src:${PYTHONPATH}
export EXPERIMENT_RUN_TIME=${duration}

cd $PWD/tribler
echo ---------------------------------------------------------------create venv
python3 -m venv ./venv
. ./venv/bin/activate

echo ------------------------------------------------------install requirements
python3 -m pip install --upgrade setuptools pip
python3 -m pip install --upgrade -r ./requirements-core.txt
python3 -m pip list

echo ------------------------------------------------------start the experiment
python3 ./scripts/experiments/tunnel_community/hidden_peer_discovery.py

export R_LIBS_USER=$R_LIBS_USER${R_LIBS_USER:+:}$HOME/R
R --no-save < ./scripts/experiments/tunnel_community/hidden_peer_discovery.r

echo -----------------------------------------------------------deactivate venv
deactivate

https://jenkins-ci.tribler.org/job/tunnel_experiments/job/hidden_peer_discovery/239/

UPD: it works

image

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a
Copy link
Contributor Author

drew2a commented Apr 4, 2022

libgcrypt20 has been installed on the Linux machine:

sudo apt install libgcrypt20-dev

Ref: https://github.com/arvidn/libtorrent/blob/RC_2_0/.github/workflows/linux.yml

@Tribler Tribler deleted a comment from kozlovsky Apr 4, 2022
@Tribler Tribler deleted a comment from kozlovsky Apr 4, 2022
@drew2a drew2a marked this pull request as ready for review April 4, 2022 10:51
@drew2a drew2a requested review from a team, xoriole and kozlovsky and removed request for a team and xoriole April 4, 2022 10:51
@drew2a drew2a merged commit fa83b4d into Tribler:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants