Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix speed_test_e2e.py #7092

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix speed_test_e2e.py #7092

merged 1 commit into from
Oct 24, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Oct 20, 2022 •
edited
Loading

This PR fixes #7088

Also, I made a change to the Jenkins job:
https://jenkins-ci.tribler.org/job/tunnel_experiments/job/speed_test_e2e/

image

image

@drew2a drew2a force-pushed the fix/7088 branch 4 times, most recently from 601e63c to 2f477a8 Compare October 20, 2022 12:57
@drew2a drew2a marked this pull request as ready for review October 20, 2022 12:58
@drew2a drew2a requested review from a team, kozlovsky, xoriole and devos50 and removed request for a team and kozlovsky October 20, 2022 12:58
@drew2a
Copy link
Contributor Author

drew2a commented Oct 21, 2022

I have not received a response from @xoriole which is why I requested reviews from @devos50 and @kozlovsky 🤝

devos50
devos50 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good. I wonder if there's a way to make the failure of this particular experiment more visible? Otherwise, we will have the same issue after another major Tribler refactoring.

@drew2a
Copy link
Contributor Author

drew2a commented Oct 24, 2022

@devos50 your point should be addressed by #7093

@drew2a drew2a merged commit 01704cf into Tribler:main Oct 24, 2022
@drew2a drew2a deleted the fix/7088 branch October 24, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devos50 devos50 devos50 approved these changes

@xoriole xoriole xoriole approved these changes

@kozlovsky kozlovsky Awaiting requested review from kozlovsky

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Jenkins] speed_test_e2e is broken
3 participants
@drew2a @xoriole @devos50