Fix unstability in test_default_sorting_with_fts #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Nov 9, 2022
kozlovsky
force-pushed
the
fix/unstability_in_test_default_sorting_with_fts
branch
from
732244c
to
52f8cc1
Compare
kozlovsky
deleted the
fix/unstability_in_test_default_sorting_with_fts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_default_sorting_with_ftscurrently works unstable because thetorrent_dateattribute of theTorrentMetadataclass got unstable values that are too close to each other, and this affects the sort order of test results. In this PR, I specify "stable" torrent creation dates that are not too close to each other and the current time, so they do not randomly affect the result sort order.