Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring GitHub Actions related to pytest #7509

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 27, 2023

This PR eliminates the profiler option that was introduced in #7135. At the time, the feature was added to identify tests that were causing timeouts during test suite execution. However, in reality, this option has never assisted us in pinpointing the actual issues.

Given that it's simpler to run the profiler on a local machine, I have decided to remove it from our GitHub Actions. This action is aimed at maintaining relative simplicity in our workflows.

Another update involves the operating system-related separation of pytest arguments. This change will facilitate the reinstatement of the xdist feature, complete with all of the fixes @kozlovsky contributed in #6176.

@drew2a drew2a mentioned this pull request Jun 27, 2023
@drew2a drew2a marked this pull request as ready for review June 27, 2023 12:47
@drew2a drew2a requested review from a team, kozlovsky and xoriole and removed request for a team and kozlovsky June 27, 2023 12:47
@drew2a
Copy link
Contributor Author

drew2a commented Jun 27, 2023

As an option, instead of writing

      - name: Run Pytest (Win)
        if: runner.os == 'Windows'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_WIN}

      - name: Run Pytest (Linux)
        if: runner.os == 'Linux'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_LINUX}

      - name: Run Pytest (Mac)
        if: runner.os == 'macOS'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_MAC}

      - name: Run Tunnels Tests (Win)
        if: runner.os == 'Windows'
        run: |
          pytest ${PYTEST_TUNNELS_ARGUMENTS_WIN}

      - name: Run Tunnels Tests (Linux)
        if: runner.os == 'Linux'
        run: |
          pytest ${PYTEST_TUNNELS_ARGUMENTS_LINUX}

      - name: Run Tunnels Tests (Mac)
        if: runner.os == 'macOS'
        run: |
          pytest ${PYTEST_TUNNELS_ARGUMENTS_MAC}

write:

      - name: Run Pytest (Win)
        if: runner.os == 'Windows'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_WIN}
          pytest ${PYTEST_TUNNELS_ARGUMENTS_WIN}

      - name: Run Pytest (Linux)
        if: runner.os == 'Linux'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_LINUX}
          pytest ${PYTEST_TUNNELS_ARGUMENTS_LINUX}


      - name: Run Pytest (Mac)
        if: runner.os == 'macOS'
        run: |
          pytest ${PYTEST_CORE_ARGUMENTS_MAC}
          pytest ${PYTEST_TUNNELS_ARGUMENTS_MAC}

@xoriole xoriole requested a review from kozlovsky June 27, 2023 13:47
@drew2a drew2a merged commit 4dfa004 into Tribler:main Jun 28, 2023
@drew2a drew2a deleted the refactoring/pytests branch June 28, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants