You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are multiple issues in the exported JavaDocs. Some of these are only present in builds by JitPack, some are also present locally. Let's use these methods as examples:
the 2nd annotation (@Contract) has whitespace before it for no reason
the method (the return value) is annotated as @NotNull twice
the parameter is annotated as @NotNull twice
there are unnecessary (and ugly) whitespace and a newline between the parameter's @NotNull annotations
the IodinePlayer.State references are not resolved (build warning: Tag @link: reference not found: IodinePlayer.State)
Issues on local (my own PC):
all annotations, parameters are on a single line: there are no linebreaks to improve readability
the method (the return value) is annotated as @NotNull twice
the parameter is annotated as @NotNull twice
This means that the only non-visual issue, the broken references, are not present locally and have something to do with JitPack's build process. They being broken must have something to do with the fact that they are references to inner classes.
Not sure what you mean by fully valid. It works, but it has the problems described in the issue. I dislike the idea of manually publishing the JavaDocs, therefore GitHub pages is not an option.
There are multiple issues in the exported JavaDocs. Some of these are only present in builds by JitPack, some are also present locally. Let's use these methods as examples:
Issues on JitPack:
@Contract
) has whitespace before it for no reason@NotNull
twice@NotNull
twice@NotNull
annotationsIodinePlayer.State
references are not resolved (build warning:Tag @link: reference not found: IodinePlayer.State
)Issues on local (my own PC):
@NotNull
twice@NotNull
twiceThis means that the only non-visual issue, the broken references, are not present locally and have something to do with JitPack's build process. They being broken must have something to do with the fact that they are references to inner classes.
The duplicate/double annotation issue is not unique to our case at all. Spigot, Paper and probably almost every other project also experiences it. Java Bug Database link: https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8175533
Thank you to Z750 and electroniccat from PaperMC for some insight regarding these issues.
The text was updated successfully, but these errors were encountered: