Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server does not handle incoming garbage #10

Open
davepacheco opened this issue Oct 11, 2017 · 0 comments
Open

server does not handle incoming garbage #10

davepacheco opened this issue Oct 11, 2017 · 0 comments

Comments

@davepacheco
Copy link
Contributor

Original bug report: MORAY-444.

The new fast implementation is careful to validate incoming data and generate errors for invalid data, but the FastServer does not handle all of these cases properly. In particular, if you make an HTTP request to the fast port (for example), the decoder will emit an error reflecting the garbage that came in, but the server doesn't handle that error, so the server crashes anyway.

Instead, the server should listen for errors on each connection's message decoder. On error, it should terminate the connection with connTerminate, just like it does in server.onMessage() when there are other types of protocol errors.

As part of fixing this, we should add a server test case to exercise this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant