Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve node-fast artedi tests #18

Open
joshwilsdon opened this issue May 15, 2018 · 0 comments
Open

improve node-fast artedi tests #18

joshwilsdon opened this issue May 15, 2018 · 0 comments

Comments

@joshwilsdon
Copy link
Contributor

With #9 and #17 node-fast has basic artedi support, but the tests are not exhaustive. @davepacheco suggested we have additional tests that validate the numbers returned but doing a good job of this will be blocked on node-artedi being able to expose these metrics in a format conducive to testing. Something like TritonDataCenter/node-artedi#11 could work. Alternatively artedi could allow a artedi.FMT_JSON format for collector.collect(). However this is resolved, once it is we should go and add more extensive tests to node-fast for the artedi support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant