We love pull requests from everyone.
Fork, then clone the repo:
git clone git@github.com:your-username/joyent/presto-manta.git
For running integration tests, you will need an account on a Manta system this could be the Joyent Public Cloud or an on-premise Manta installation.
Set up your machine:
You will need to set the following environment variables (or their aliases): MANTA_URL, MANTA_USER, MANTA_KEY_ID, MANTA_KEY_PATH
It may be useful to install the node.js triton utility to verify that you can connect to Manta before running the tests:
npm install -g manta
Make sure all tests including the integration tests pass:
mvn verify
Make your change. Add tests for your change. Make sure that all tests and style checks pass:
mvn checkstyle:checkstyle -Dcheckstyle.skip=false verify
Add your changes to the CHANGELOG.md and commit.
Push to your fork and submit a pull request.
At this point you're waiting on us. We like to at least comment on pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted:
- Filing a github issue describing the improvement or the bug before you start work.
- Write tests.
- Follow the style defined in (checkstyle.xml)[checkstyle.xml].
- Write a good commit message.