Thanks for using Triton and for considering contributing to it!
All changes to Triton project repositories go through code review. This repository uses GitHub pull requests (PRs)
If you're making a substantial change, you probably want to contact developers on the mailing list or IRC first. If you have any trouble with the contribution process, please feel free to contact developers on the mailing list or IRC. Note that larger Triton project changes are typically designed and discussed via "Requests for Discussion (RFDs)".
Triton repositories use the Triton Engineering Guidelines. Notably:
- The #master branch should be first-customer-ship (FCS) quality at all times. Don't push anything until it's tested.
- All repositories should be "make check" clean at all times.
- All repositories should have tests that run cleanly at all times.
There are two separate issue trackers that are relevant for Triton code:
-
An internal JIRA instance.
A JIRA ticket has an ID like
IMGAPI-536, where "IMGAPI" is the JIRA project name -- in this case used by the sdc-imgapi and related repos. A read-only view of most JIRA tickets is made available at https://smartos.org/bugview/ (e.g. https://smartos.org/bugview/IMGAPI-536). -
GitHub issues for the relevant repo, e.g. https://github.com/TritonDataCenter/triton/issues.
Before Triton was open sourced, Triton engineering used a private JIRA instance. While we continue to use JIRA internally, we also use GitHub issues for tracking -- primarily to allow interaction with those without access to JIRA.