Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnectV2 Connector Build Issue #1117

Open
cbonaco1 opened this issue Jun 28, 2023 · 4 comments
Open

WalletConnectV2 Connector Build Issue #1117

cbonaco1 opened this issue Jun 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@cbonaco1
Copy link

First want to mention that my team and I ❤️ useDApp. nice work!

Describe the bug
We ran into issues using the @usedapp/wallet-connect-v2-connector package while upgrading to WalletConnect v2. We included the connector as a dependency, but saw the below build error:

10:27:40.718 | Error [ERR_REQUIRE_ESM]: require() of ES Module /opt/buildhome/repo/node_modules/@web3modal/standalone/dist/index.es.js from /opt/buildhome/repo/node_modules/@usedapp/wallet-connect-v2-connector/dist/cjs/src/index.js not supported.
10:27:40.718 | Instead change the require of index.es.js in /opt/buildhome/repo/node_modules/@usedapp/wallet-connect-v2-connector/dist/cjs/src/index.js to a dynamic import() which is available in all CommonJS modules.
10:27:40.718 | at Object.<anonymous> (/opt/buildhome/repo/node_modules/@usedapp/wallet-connect-v2-connector/dist/cjs/src/index.js:45:20)

Looking into this, I did see @web3modal/standalone is a dependency of the walletConnectv2 connector, which according to npm is deprecated. should this possibly use @walletconnect/modal instead?

To Reproduce
Here is our useDApp config:

const config: Config = {
  readOnlyChainId: currentChainId,
  readOnlyUrls: {
    [currentChainId]: `https://${
      currentChainId === Mainnet.chainId ? 'mainnet' : 'goerli'
    }.infura.io/v3/${process.env.NEXT_PUBLIC_INFURA_ID ?? ''}`,
  },
  refresh: 'never',
  connectors: {
    metamask: new MetamaskConnector(),
    walletConnect: new WalletConnectV2Connector({
      projectId: process.env.NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID || '',
      chains: currentChainId === Mainnet.chainId ? [Mainnet] : [Goerli],
    }),
  },
};

Then from our own modal, onClick of the WalletConnect button, we have just the following:

activateBrowserWallet({ type: 'walletConnect' });

Software versions

  • @usedapp/core@1.2.10
  • @usedapp/wallet-connect-v2-connector@1.0.2
  • Package manager npm
  • Node version 16

Any guidance here is appreciated 🙏

@cbonaco1 cbonaco1 added the bug Something isn't working label Jun 28, 2023
@tamebadger
Copy link

seeing the same issue here, additionally using next.js & yarn, same version of usedapp/core

@DanielKlys7
Copy link

Any fixes? 🤔

@yivlad
Copy link
Collaborator

yivlad commented Jul 4, 2023

Have you tried including something like this in your bundler confg?

@yivlad
Copy link
Collaborator

yivlad commented Jul 4, 2023

@usedapp/wallet-connect-v2-connector@1.0.3 is now available on npm. Could you please try it out and let me know if this solves the problem? I replaced @web3modal/standalone with @walletconnect/modal as @cbonaco1 suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants