Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new line at the end of the metric's network data representation #9

Open
sanjaiganesh opened this issue Apr 15, 2019 · 2 comments

Comments

@sanjaiganesh
Copy link

@TerribleDev
We are trying to use this library (thanks) and noticed that it adds 'new line char' to the end of the network stream, even for single metric.
Due to this, metric upload failing in our environment.
Per StatsD protocol, newlines used to separate when multiple metrics are transfered in single payload (not for single metric).

If you agree, I could create a PR to change the behavior.

nternal Task SendMetric(string metric)
{
var payload = Encoding.ASCII.GetBytes(metric + Environment.NewLine);
if (Options.BufferMetrics)
{
..........................................
}
return SendAsync(payload);
}

@TerribleDev
Copy link
Member

sure np

@TerribleDev
Copy link
Member

@sanjaiganesh havn't seen any Pull requests from you yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants