Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tape -> tap, set minimum coverage #328

Closed
tmcw opened this issue Mar 6, 2016 · 5 comments
Closed

tape -> tap, set minimum coverage #328

tmcw opened this issue Mar 6, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@tmcw
Copy link
Collaborator

tmcw commented Mar 6, 2016

No description provided.

@tmcw tmcw assigned tmcw and unassigned tmcw Mar 20, 2016
@tmcw
Copy link
Collaborator Author

tmcw commented May 15, 2016

Going to stay with tape for 3.x, only switch to tap once we figure some other details out.

@DenisCarriere
Copy link
Member

@tmcw Looking to hear your feedback, tap seems like a good solution for Turf.
Can I ask what those details to figure out were?

#713

@DenisCarriere
Copy link
Member

Just found out that tap seamlessly integrates with coveralls.io without any additional configurations or changes in the package.json.

http://www.node-tap.org/cli/

If a COVERALLS_REPO_TOKEN environment variable is set, then coverage is captured by default and sent to the coveralls.io service.

package.json - no change (other than node test.js => tap test.js)

  "scripts": {
    "test": "tap test.js",
    "bench": "node bench.js"
  },

test.js - only require changes (NodeJS >=6)

const {test} = require('tap');

@DenisCarriere DenisCarriere reopened this May 23, 2017
@DenisCarriere DenisCarriere self-assigned this May 23, 2017
@DenisCarriere DenisCarriere added this to the 4.4.0 milestone May 23, 2017
@DenisCarriere
Copy link
Member

Woot! It works! level of effort Zero!

image

@DenisCarriere
Copy link
Member

Added tap as main testing suite, using tap in each repo is optional, both tape or tap works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants