Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate @turf/idw ? #887

Closed
stebogit opened this issue Aug 3, 2017 · 3 comments
Closed

Deprecate @turf/idw ? #887

stebogit opened this issue Aug 3, 2017 · 3 comments

Comments

@stebogit
Copy link
Collaborator

stebogit commented Aug 3, 2017

Since we implemented the new @turf/interpolate, which uses the same Inverse Distance Weighting (IDW) method algorithm and can output different types of grids, we should probably deprecate @turf/idw.
Ref #832 (comment).

I'd suggest however a performance tune of interpolate, which seems to be a little slower than idw, probably due to the use of featureEach.

Maybe we could add now a warning message like we did for @turf/clusters #846

@DenisCarriere
Copy link
Member

👍 Sounds like a plan!

You need to use npm to deprecate a module, more info here:
https://docs.npmjs.com/cli/deprecate

However you would need npm publishing rights to do that.

@DenisCarriere
Copy link
Member

DenisCarriere commented Aug 3, 2017

Added deprecated warning message.

$ npm install @turf/idw
npm WARN deprecated @turf/idw@4.6.1: module will be replaced with @turf/interpolate
/Users/mac/Github/test
└─┬ @turf/idw@4.6.1 
  ├─┬ @turf/bbox@4.6.0 
  │ └── @turf/meta@4.6.0 
  ├─┬ @turf/centroid@4.6.1 
  │ └── @turf/helpers@4.6.0 
  ├─┬ @turf/distance@4.6.0 
  │ └── @turf/invariant@4.6.0 
  └── @turf/square-grid@4.6.0 

@DenisCarriere
Copy link
Member

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants