Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write FAQ/Guidelines for cache getters regarding background refreshes #18

Closed
Turnerj opened this issue Nov 3, 2019 · 3 comments
Closed
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@Turnerj
Copy link
Member

Turnerj commented Nov 3, 2019

Because CacheStack supports background refreshing, it is important to make sure it doesn't access disposed instances. Guidelines and examples should be provided for accessing/querying a database and utilising the context that is passed into the getter.

@Turnerj Turnerj added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 3, 2019
@Turnerj
Copy link
Member Author

Turnerj commented Mar 22, 2020

This should be naturally more intuitive thanks to #20 / #21 though still should be done.

@Turnerj Turnerj added this to the v1.0 milestone May 12, 2020
@Turnerj Turnerj added the help wanted Extra attention is needed label Jun 4, 2020
@Turnerj
Copy link
Member Author

Turnerj commented Mar 4, 2021

There have been many improvements to documentation to date however this is still not covered yet.

@Turnerj
Copy link
Member Author

Turnerj commented Mar 5, 2021

Readme has been updated to note about avoiding disposed contexts.

@Turnerj Turnerj closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant