Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double tap required on mobile devices #166

Closed
floAtEbcont opened this issue Sep 18, 2018 · 2 comments · Fixed by #167
Closed

Double tap required on mobile devices #166

floAtEbcont opened this issue Sep 18, 2018 · 2 comments · Fixed by #167
Assignees
@scttcper

Comments

@floAtEbcont
Copy link
Contributor

When selecting an emoji from the picker on a touch screen device (I tried it on iPhone SE & iPad), two taps are required to trigger the emojiSelect and/or emojiClick events and close the picker.
That behavior might well be intended! (Otherwise, if [showPreview]="true" is set it would be impossible to see said preview.)

However - when setting [showPreview]="true" it would be useful to have it react to a single tap. Therefore I suggest adding a new boolean Input (e.g. emitOnTouch) that causes this behavior.
floAtEbcont added a commit to floAtEbcont/ngx-emoji-mart that referenced this issue Sep 18, 2018
@floAtEbcont
Closes scttcper#166
5544810
@floAtEbcont floAtEbcont mentioned this issue Sep 18, 2018
Merged
@scttcper scttcper self-assigned this Sep 18, 2018
scttcper pushed a commit that referenced this issue Sep 19, 2018
@floAtEbcont @scttcper
feat: allow single tap selection on mobile devices (#167)
fe0a23a 
This is would be one possibility to solve #166 

closes #166
@scttcper
Copy link
Owner

🎉 This issue has been resolved in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edenchen123
Copy link

@scttcper tap still not working

"@ctrl/ngx-emoji-mart": "^0.14.0",
Iphone X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scttcper scttcper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow single tap selection on mobile devices floAtEbcont/ngx-emoji-mart
3 participants
@scttcper @edenchen123 @floAtEbcont