Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `` inside of Marked Link Brackets #1091

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

forivall
Copy link
Contributor

No description provided.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Sep 1, 2019

Question, does `[[ link ]]` not work as intended? With the current behavior, the text inside brackets is taken (almost) verbatim to find symbols, and while ` isn't a very common symbol, it still introduces some complexity that it would be nice to avoid.

@forivall
Copy link
Contributor Author

forivall commented Sep 1, 2019 via email

@socsieng
Copy link
Contributor

Question, does `[[ link ]]` not work as intended? With the current behavior, the text inside brackets is taken (almost) verbatim to find symbols, and while ` isn't a very common symbol, it still introduces some complexity that it would be nice to avoid.

Using the back ticks outside of the links results in the anchor being displayed as code as opposed to the code inside the anchor tag.

My current work-around for this is:

[[MyClass.attribute|`MyClass.attribute`]]

I would obviously prefer:

[[`MyClass.attribute`]]

Any chance of this getting merged?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 18, 2020

I've been putting this off for a bit since I also want to update the docs surrounding linking but haven't gotten around to it. Notably, using {@linkcode MyClass.attribute} will also produce a link with code in the anchor tag, but isn't documented anywhere.

@Gerrit0 Gerrit0 added this to the 0.17 milestone Jan 18, 2020
@Gerrit0 Gerrit0 merged commit 1ec2fb8 into TypeStrong:master Feb 28, 2020
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 28, 2020

Released in 0.16.11 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants